From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8411D441841 for ; Wed, 25 Mar 2020 16:38:37 +0300 (MSK) Date: Wed, 25 Mar 2020 16:38:39 +0300 From: Alexander Turenko Message-ID: <20200325133839.pclhy6c7rjgkrdfk@tkn_work_nb> References: <1585138345.846789982@f416.i.mail.ru> <20200325123007.ttvttnuev3xxf5ey@tkn_work_nb> <1585141973.158554584@f136.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1585141973.158554584@f136.i.mail.ru> Subject: Re: [Tarantool-patches] [PATCH v2] test: fix OSX host setup List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Tikhonov Cc: Oleg Piskunov , tarantool-patches@dev.tarantool.org > >> >> + brew update || echo | /usr/bin/ruby -e \ > >> >> + "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install )" > >> > > >> >Why don't update formulae after installing brew? > >> > >> The tapped formula does not exist in brew any more, though it can’t be > >> updated. > > > >After installing brew you'll have fresh brew, but no formulae, I guess. > >Will the next `brew install` work? I guess, no. You need `brew update` > >after this. > > I’ve tried to remove the brew and reinstalled it with this command, > seems that all needed updates were tried to do during the > installation: Okay so. > >> >From the previous review [1]: > >> > > >> >> > The problem with 'var' directory is not related to the new way to Python > >> >> > 2 installation? Why everything is in one commit? > >> >> > >> >> This commit is about OSX host setup for building and testing, so I > >> >> think it is ok to set it here. > >> > > >> >It sounds as 'because something going not right, when something was > >> >changed'. Neat reason. > >> > > >> >I cannot say neither 'ok', not 'not ok' for this. Okay, I can guess that > >> >working directory is changed somehow, but why and where? > >> > >> ‘var’ directory lays too deep at the path and the length of the path > >> is too long for test-run.py tool which fails because of it, the > >> solution to fix it is to use the short link for the ‘var’ directory. > > > >Why it was okay, but becomes too long? > Because the name of the user on the new mac mini and its home path is really long > echo ~ | wc -c >       28 > also the path of tarantool/test/var adds. Okay, so it worth to state something like: > We're going to enable new Mac machines into CI and usernames on them > are long according to internal policies. It makes a home directory to > be long too and so a path to a unix socket created during testing can > be longer then UNIX_PATH_MAX constant (108). Move the working > directory for testing into <...>. It would be also good to link the issue, which describes some details around the path length limit: https://github.com/tarantool/tarantool/issues/4634