From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2800D441841 for ; Wed, 25 Mar 2020 11:33:57 +0300 (MSK) Received: by mail-lf1-f66.google.com with SMTP id j188so1016656lfj.11 for ; Wed, 25 Mar 2020 01:33:57 -0700 (PDT) Date: Wed, 25 Mar 2020 11:33:55 +0300 From: Konstantin Osipov Message-ID: <20200325083355.GE18984@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v2 04/10] box/error: introduce box.error.set() method List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Nikita Pettik [20/03/25 09:32]: > box.error.set(err) sets err to instance's diagnostics area. Argument err > is supposed to be instance of error object. This method is required > since we are going to avoid adding created via box.error.new() errors to > Tarantool's diagnostic area. I agree that it's a good idea to separate creation and addition in Lua. I don't know if it breaks anything, but please search on github for box.error.new. This is not easy to do, since github doesn't support '.' in searches, so perhaps you should do: for each (repo in github/tarntool and moonlibs) git clone repo cd repo git grep -r 'box.error.new' . Most likely there is some obscure place you break. -- Konstantin Osipov, Moscow, Russia