From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1A19A43E880 for ; Mon, 23 Mar 2020 19:42:06 +0300 (MSK) Received: by mail-lj1-f193.google.com with SMTP id r22so8287385ljh.0 for ; Mon, 23 Mar 2020 09:42:06 -0700 (PDT) Date: Mon, 23 Mar 2020 19:42:04 +0300 From: Konstantin Osipov Message-ID: <20200323164204.GD5491@atlas> References: <6e19af47fb3ed97ac4c03bd1f6e128375feb2d48.1584978381.git.sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e19af47fb3ed97ac4c03bd1f6e128375feb2d48.1584978381.git.sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v3 3/4] replication: hide 0-th vclock components in replication responses List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Serge Petrenko [20/03/23 19:23]: > If an anonymous replica is promoted to a normal one and becomes > replication master later, its vclock contains a non-empty zero > component, tracking local changes on this replica from the time when it > had been anonymous. No need to pollute joining instance's vclock with > our non-empty 0 component. > When an anonymous replica reports its status to a remote instance it > should also hide its 0-th vclock component. The patches for anonymous replicas were pushed without my review. I think whoever reviewed them should review these patches as well. -- Konstantin Osipov, Moscow, Russia https://scylladb.com