From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 09E144696C3 for ; Mon, 23 Mar 2020 09:59:31 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id g12so13291221ljj.3 for ; Sun, 22 Mar 2020 23:59:31 -0700 (PDT) Date: Mon, 23 Mar 2020 09:59:30 +0300 From: Konstantin Osipov Message-ID: <20200323065930.GA11962@atlas> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH v4 04/11] coio: do not throw an error, minor refactoring List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Georgy Kirichenko Cc: tarantool-patches@dev.tarantool.org * Georgy Kirichenko [20/02/12 13:09]: > Relaying from C-written wal requires coio and xrow_io to be > a C-compliant. So get rid of exception from coio interface. > Also this patch includes some minor refactoring (as code looks ugly > without them): > 1. Get rid of unused size_hint from coio_writev_timeout. > 2. Handle partial read/write before yield loop. > 3. Do not reset errno to 0 in case of reading EOF. This patch is LGTM but requires a more careful second review. -- Konstantin Osipov, Moscow, Russia