From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1D723442BAE for ; Fri, 20 Mar 2020 22:40:21 +0300 (MSK) Received: by mail-lj1-f181.google.com with SMTP id u12so7763754ljo.2 for ; Fri, 20 Mar 2020 12:40:21 -0700 (PDT) Date: Fri, 20 Mar 2020 22:40:18 +0300 From: Konstantin Osipov Message-ID: <20200320194018.GE9483@atlas> References: <59ece61283f53c6d2772b81ffc8a783873ef4b0b.1584703666.git.korablev@tarantool.org> <20200320133333.GB29536@atlas> <20200320150639.GC14930@tarantool.org> <20200320174044.GA5670@atlas> <20200320182423.GA15920@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320182423.GA15920@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Nikita Pettik [20/03/20 21:29]: > > The problem is pretty minor. The fix is actually not necessarily > > the best one, too (but seems adequate for 1.10). > > Could you please mention other ways to fix it? I'm still new in vinyl, > so it would be helpful to me to investigate all possible solutions and > workarounds. Thanks. 1) I'm really am not motivated to do it after the patch is pushed like that. 2) There is vy_mem_pin/vy_mem_unpin which is used to pin the mem during yields. Generally the mem we're working with should not be kicked out of memory inside vy_build_insert_tuple, except for when we deliberately wish it to happen in vy_quota_wait(). -- Konstantin Osipov, Moscow, Russia https://scylladb.com