From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 118F7469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 20 Mar 2020 21:24:24 +0300 (MSK)
Date: Fri, 20 Mar 2020 18:24:23 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200320182423.GA15920@tarantool.org>
References: <59ece61283f53c6d2772b81ffc8a783873ef4b0b.1584703666.git.korablev@tarantool.org>
 <20200320133333.GB29536@atlas>
 <20200320150639.GC14930@tarantool.org>
 <20200320174044.GA5670@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200320174044.GA5670@atlas>
Subject: Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in
 vy_build_insert_tuple() after yield
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

On 20 Mar 20:40, Konstantin Osipov wrote:
> * Nikita Pettik <korablev@tarantool.org> [20/03/20 18:07]:
> > > * Nikita Pettik <korablev@tarantool.org> [20/03/20 15:41]:
> > > > vy_build_insert_tuple() processes insertion into secondary indexes being
> > > > created. It contains yield points during which in-memory level of LSM
> > > > tree may change (for example rotate owing to triggered dump). So after
> > > > yield point it is required to fetch from LSM struct pointer to mem again
> > > > to operate on valid metadata. This patch updates pointer to mem after
> > > > mentioned yield point.
> > > 
> > > The patch is LGTM, how long does the test run? 
> > 
> > Up to ~5 seconds as a rule.
> >  
> > > Can you add it to an existing low-quota test, to avoid
> > > setup/teardown overhead for such a minor fix?
> > 
> > Ok. But I woudn't say it is minor - bug leads to crashes under
> > highload on customer's servers :)
> 
> The problem is pretty minor. The fix is actually not necessarily
> the best one, too (but seems adequate for 1.10).

Could you please mention other ways to fix it? I'm still new in vinyl,
so it would be helpful to me to investigate all possible solutions and
workarounds. Thanks.
 
> -- 
> Konstantin Osipov, Moscow, Russia