From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D0DD9469719 for ; Fri, 20 Mar 2020 18:23:23 +0300 (MSK) Date: Fri, 20 Mar 2020 18:23:23 +0300 From: Kirill Yukhin Message-ID: <20200320152322.4cjwdfx7sqlnvxve@tarantool.org> References: <59ece61283f53c6d2772b81ffc8a783873ef4b0b.1584703666.git.korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <59ece61283f53c6d2772b81ffc8a783873ef4b0b.1584703666.git.korablev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org Hello, On 20 мар 15:32, Nikita Pettik wrote: > vy_build_insert_tuple() processes insertion into secondary indexes being > created. It contains yield points during which in-memory level of LSM > tree may change (for example rotate owing to triggered dump). So after > yield point it is required to fetch from LSM struct pointer to mem again > to operate on valid metadata. This patch updates pointer to mem after > mentioned yield point. > > Closes #4810 > --- > Branch: https://github.com/tarantool/tarantool/tree/np/gh-4810-dump-during-index-build > Issue: https://github.com/tarantool/tarantool/issues/4810 The patch LGTM. I've checked it into 1.10, 2.2, 2.3 and master. -- Regards, Kirill Yukhin