From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D8F41469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 20 Mar 2020 17:33:58 +0300 (MSK)
Date: Fri, 20 Mar 2020 17:27:41 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200320142741.GT6392@tarantool.org>
References: <cover.1584708367.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <cover.1584708367.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] test: cleanup tests code
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Kirill,

Please proceed with the series.

On 20.03.20, Alexander V. Tikhonov wrote:
> test: cleanup tests code
>     
> Cleaned up the tests code according to the Lua style guide:
> - made scoped variables local
> - added os.exit call at the end of the test chunk
> - adjusted the messages in test:ok calls
> 
> Renamed test files in the following way:
> <repo>-<number>-<comment>.test.lua
> where "<repo>" is github repository:
>   gh - tarantool/tarantool
>   lj - LuaJIT/LuaJIT
>   or - openresty/luajit2
>     
> Close #4655
> 
> ---
> 
> Github: https://github.com/tarantool/luajit/tree/avtikhon/gh-4655-cleanup-tests
> Issue: https://github.com/tarantool/tarantool/issues/4655
> 
> commit 1a00fc69881893cc376e78815fdfee12b9e038b3
> Author: Alexander V. Tikhonov <avtikhon@tarantool.org>
> Date:   Wed Dec 11 17:24:16 2019 +0300
> 
> Alexander V. Tikhonov (2):
>   test: cleanup tests code
>   test: rename test files
> 
>  ... gh-3196-incorrect-string-length.test.lua} |  8 +++----
>  ...h-4476-fix-string-find-recording.test.lua} |  6 ++---
>  ...lj-494-table-chain-infinite-loop.test.lua} | 23 ++++++++++---------
>  ...j-505-fold-no-strref-for-ptrdiff.test.lua} |  7 +++---
>  ...lj-524-fold-conv-respect-src-irt.test.lua} |  4 ++--
>  ...est.lua => or-232-unsink-64-kptr.test.lua} |  7 +++---
>  6 files changed, 29 insertions(+), 26 deletions(-)
>  rename test/{gh.test.lua => gh-3196-incorrect-string-length.test.lua} (56%)
>  rename test/{fix_string_find_recording.test.lua => gh-4476-fix-string-find-recording.test.lua} (95%)
>  rename test/{table_chain_bug_LuaJIT_494.test.lua => lj-494-table-chain-infinite-loop.test.lua} (89%)
>  rename test/{fold_bug_LuaJIT_505.test.lua => lj-505-fold-no-strref-for-ptrdiff.test.lua} (68%)
>  rename test/{fold_bug_LuaJIT_524.test.lua => lj-524-fold-conv-respect-src-irt.test.lua} (85%)
>  rename test/{unsink_64_kptr.test.lua => or-232-unsink-64-kptr.test.lua} (86%)
> 
> -- 
> 2.17.1
> 

-- 
Best regards,
IM