From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 75AC6469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 20 Mar 2020 16:58:03 +0300 (MSK)
Date: Fri, 20 Mar 2020 16:58:02 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200320135802.zxxvtlchkwb56gb2@tarantool.org>
References: <20200320081956.30650-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200320081956.30650-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v15 00/11] journal redesign sync and
 async writes
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

Hello,

On 20 мар 11:19, Cyrill Gorcunov wrote:
> https://gitlab.com/tarantool/tarantool/pipelines/128055422
> gorcunov/gh-4031-txn_write_to_wal-15
> 
> in v15:
>  - dropped txn.h inclusion into wal and journal
>  - use asserts in no-async-write journal stubs
> 
> Cyrill Gorcunov (11):
>   box: recovery_journal_create -- set journal here
>   box: recovery_journal -- declare it as static
>   box/txn: move fiber_set_txn to header
>   box/txn: rename txn_write to txn_commit_async
>   box/txn: move setup of txn start to txn_prepare
>   box/txn: add txn_commit_nop helper
>   box/txn: rename txn_entry_complete_cb to txn_complete_async
>   box/txn: unweave txn_commit from txn_commit_async
>   box/txn: clear fiber storage right before journal write
>   box/txn: move journal allocation into separate routine
>   box/journal: redesign journal operations

LGTM.

I've checked your patchset into master. And we'll probably back
port it into 2.3.

--
Regards, Kirill Yukhin