From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5DCCA469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 20 Mar 2020 16:52:22 +0300 (MSK)
Date: Fri, 20 Mar 2020 16:46:04 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200320134604.GR6392@tarantool.org>
References: <cover.1584708367.git.avtikhon@tarantool.org>
 <1a00fc69881893cc376e78815fdfee12b9e038b3.1584708367.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1a00fc69881893cc376e78815fdfee12b9e038b3.1584708367.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 1/2] test: cleanup tests code
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sasha,

Thanks for the patch! LGTM except the one general nit: please adjust
test:ok messages considering those I proposed in the previous review.

New series is not needed, just update the remote branch.

On 20.03.20, Alexander V. Tikhonov wrote:
> Cleaned up the tests code according to the Lua style guide:
> - made scoped variables local
> - added os.exit call at the end of the test chunk
> - adjusted the messages in test:ok calls
> 
> Part of #4655
> ---
>  test/fix_string_find_recording.test.lua  |  6 +++---
>  test/fold_bug_LuaJIT_505.test.lua        |  7 ++++---
>  test/fold_bug_LuaJIT_524.test.lua        |  4 ++--
>  test/gh.test.lua                         |  8 ++++----
>  test/table_chain_bug_LuaJIT_494.test.lua | 23 ++++++++++++-----------
>  test/unsink_64_kptr.test.lua             |  7 ++++---
>  6 files changed, 29 insertions(+), 26 deletions(-)
> 

<snipped>

> -- 
> 2.17.1
> 

-- 
Best regards,
IM