From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com [209.85.167.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 83BF1469719 for ; Fri, 20 Mar 2020 16:33:35 +0300 (MSK) Received: by mail-lf1-f67.google.com with SMTP id j188so696000lfj.11 for ; Fri, 20 Mar 2020 06:33:35 -0700 (PDT) Date: Fri, 20 Mar 2020 16:33:33 +0300 From: Konstantin Osipov Message-ID: <20200320133333.GB29536@atlas> References: <59ece61283f53c6d2772b81ffc8a783873ef4b0b.1584703666.git.korablev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59ece61283f53c6d2772b81ffc8a783873ef4b0b.1584703666.git.korablev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] vinyl: update mem ptr in vy_build_insert_tuple() after yield List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Nikita Pettik [20/03/20 15:41]: > vy_build_insert_tuple() processes insertion into secondary indexes being > created. It contains yield points during which in-memory level of LSM > tree may change (for example rotate owing to triggered dump). So after > yield point it is required to fetch from LSM struct pointer to mem again > to operate on valid metadata. This patch updates pointer to mem after > mentioned yield point. The patch is LGTM, how long does the test run? Can you add it to an existing low-quota test, to avoid setup/teardown overhead for such a minor fix? -- Konstantin Osipov, Moscow, Russia