From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 64C2B469719 for ; Fri, 20 Mar 2020 14:15:42 +0300 (MSK) Date: Fri, 20 Mar 2020 14:15:41 +0300 From: Kirill Yukhin Message-ID: <20200320111541.tiqcm27btztslate@tarantool.org> References: <20200305113600.65203-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200305113600.65203-1-sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] vclock: refactor vclock map to use type uint32_t List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 05 мар 14:36, Serge Petrenko wrote: > We're using an unsigned int to hold vclock map, but there is no > guarantee that unsigned int will be 4 bytes in size to fit all the 32 > vclock components. So use uint32_t instead. > --- > No issue, discussed in scope of > https://github.com/tarantool/tarantool/issues/4739 > Branch: https://github.com/tarantool/tarantool/tree/sp/vclock-map-refactor I've checked your patch into 2.2, 2.3 and master. -- Regards, Kirill Yukhin