From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CF00A469719 for ; Fri, 20 Mar 2020 13:17:39 +0300 (MSK) Received: by mail-lj1-f195.google.com with SMTP id d23so5729944ljg.13 for ; Fri, 20 Mar 2020 03:17:39 -0700 (PDT) Date: Fri, 20 Mar 2020 13:17:36 +0300 From: Cyrill Gorcunov Message-ID: <20200320101736.GC8326@uranus> References: <20200320081956.30650-1-gorcunov@gmail.com> <20200320081956.30650-4-gorcunov@gmail.com> <20200320101335.GA20273@atlas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200320101335.GA20273@atlas> Subject: Re: [Tarantool-patches] [PATCH v15 03/11] box/txn: move fiber_set_txn to header List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Konstantin Osipov , tml On Fri, Mar 20, 2020 at 01:13:35PM +0300, Konstantin Osipov wrote: > * Cyrill Gorcunov [20/03/20 11:20]: > > We will use it inside wal engine. > > > > Moreover we already have a "get" function in this header > > which is named in_txt(). Having both get/set in one place > > should be more consistent. > > > > Acked-by: Konstantin Osipov > > Signed-off-by: Cyrill Gorcunov > > --- > > src/box/txn.c | 6 ------ > > src/box/txn.h | 7 +++++++ > > 2 files changed, 7 insertions(+), 6 deletions(-) > > You could drop this commit now perhaps. While it is not longer used in wal. I think it is more consistent to have set/get functions in one place? Thus if you're not strictly against I would keep it (except I need to update the changelog pointing that the commit is not because of wal)