From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 35B45469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 20 Mar 2020 13:13:37 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id d23so5717885ljg.13
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 20 Mar 2020 03:13:37 -0700 (PDT)
Date: Fri, 20 Mar 2020 13:13:35 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200320101335.GA20273@atlas>
References: <20200320081956.30650-1-gorcunov@gmail.com>
 <20200320081956.30650-4-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200320081956.30650-4-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v15 03/11] box/txn: move
	fiber_set_txn to header
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

* Cyrill Gorcunov <gorcunov@gmail.com> [20/03/20 11:20]:
> We will use it inside wal engine.
> 
> Moreover we already have a "get" function in this header
> which is named in_txt(). Having both get/set in one place
> should be more consistent.
> 
> Acked-by: Konstantin Osipov <kostja.osipov@gmail.com>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>  src/box/txn.c | 6 ------
>  src/box/txn.h | 7 +++++++
>  2 files changed, 7 insertions(+), 6 deletions(-)

You could drop this commit now perhaps.

-- 
Konstantin Osipov, Moscow, Russia