From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B5172469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 20 Mar 2020 10:09:22 +0300 (MSK)
Date: Fri, 20 Mar 2020 10:09:21 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200320070921.GA11302@pony.bronevichok.ru>
References: <20200319102458.GA73894@pony.bronevichok.ru>
 <20200319213159.GB14296@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200319213159.GB14296@atlas>
Subject: Re: [Tarantool-patches] [PATCH v2] Split box/hash.test.lua to a set
 of small independent tests
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, tarantool-patches@dev.tarantool.org, Oleg Piskunov <o.piskunov@tarantool.org>

On 00:31 Fri 20 Mar , Konstantin Osipov wrote:
> * Sergey Bronnikov <sergeyb@tarantool.org> [20/03/19 13:25]:
> > Splitted single hash.test.lua to a set of small independent tests.
>
> No rationale?

No, there are.
Right now the most tarantool tests looks like a huge unstructured pieces
of code. There are no clear boundaries between testcases and it is
unclear what we want to test exactly, sometimes comments understand
these boundaries. Often setup/teardown mixed between testcases and
testcases doesn't make cleanup at the end. It means that tests left
'dirty' environment and it may affect next testcases.

I want to follow pattern AAA (Act-Arrange-Assert) in tarantool tests in
future and make tests more clear, maintainable and stable. Splitting
huge tests for an independent testcase is a first step into this
direction. Perhaps we can split testcases into separate functions, but
AFAIK test-run.py cannot manage Lua functions as a separate testcases.

> --
> Konstantin Osipov, Moscow, Russia

--
sergeyb@