From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C4CAB441844 for ; Thu, 19 Mar 2020 17:59:38 +0300 (MSK) Date: Thu, 19 Mar 2020 17:53:21 +0300 From: Igor Munkin Message-ID: <20200319145321.GL6392@tarantool.org> References: <189a6d9e98ba6a3fa03cf0b544dd7b7e06892395.1583191602.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <189a6d9e98ba6a3fa03cf0b544dd7b7e06892395.1583191602.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 3/3] swim: use fiber._internal.schedule_task() for GC List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Vlad, Thanks for the patch, LGTM. On 03.03.20, Vladislav Shpilevoy wrote: > swim object created a new fiber in its GC function, because C > function swim_delete() yields, and can't be called from an ffi.gc > hook. > > It is not needed since the fiber module has a single worker > exactly for such cases. The patch uses it. > > Follow up #4727 > --- > src/lua/swim.lua | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) > > -- Best regards, IM