From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5F6A9469719 for ; Thu, 19 Mar 2020 17:47:37 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id o10so2781311ljc.8 for ; Thu, 19 Mar 2020 07:47:37 -0700 (PDT) Date: Thu, 19 Mar 2020 17:47:34 +0300 From: Konstantin Osipov Message-ID: <20200319144734.GA25632@atlas> References: <20200305113600.65203-1-sergepetrenko@tarantool.org> <20200316203126.GA14539@atlas> <9F39AC96-CB98-4678-8324-9369F327D4FB@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9F39AC96-CB98-4678-8324-9369F327D4FB@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] vclock: refactor vclock map to use type uint32_t List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy * Serge Petrenko [20/03/19 17:40]: > > I’ve searched once again and couldn’t find any other references to vclock map > except the ones that were already fixed in the patch. Uhm, sorry, I mixed up vclock map data type and server id data type, which are dependent. Most of places in the code uses 'unsigned' for server id data type. Perhaps we should introduce a typedef for it as well. -- Konstantin Osipov, Moscow, Russia