From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DC30B469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 19 Mar 2020 14:17:52 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id g12so2015445ljj.3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 19 Mar 2020 04:17:52 -0700 (PDT)
Date: Thu, 19 Mar 2020 14:17:49 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200319111749.GX27301@uranus>
References: <20200319090537.5613-1-gorcunov@gmail.com>
 <20200319090537.5613-12-gorcunov@gmail.com>
 <20200319103749.GC11867@atlas> <20200319104951.GV27301@uranus>
 <20200319111206.GA14895@atlas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200319111206.GA14895@atlas>
Subject: Re: [Tarantool-patches] [PATCH v13 11/11] box/journal: redesign
	journal operations
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

On Thu, Mar 19, 2020 at 02:12:06PM +0300, Konstantin Osipov wrote:
> * Cyrill Gorcunov <gorcunov@gmail.com> [20/03/19 13:51]:
> 
> I really it's not worth it, adding a cicrular dependency.
> 
> you can declare struct txn in wal.cc, and pass it around by
> pointer without using the header.
> 
> The whole goal of this refactoring was to move fiber_set_txn() 
> outside wal.cc, to txn.cc.
> 
> Is it still impossible? let's discuss.

Kostya, letme try. I think I can move txn related stuff to
the journal.c, and wal.c won't need it. Gimme some time...

> 
> Module boundaries are really important long term. You add it for a
> valid reason, and some other patch will begin using txn inside wal
> for a silly reason.

Yes, I know what is bothering you and completely agree.