From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5674A469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 19 Mar 2020 13:37:51 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id u12so1885757ljo.2
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 19 Mar 2020 03:37:51 -0700 (PDT)
Date: Thu, 19 Mar 2020 13:37:49 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200319103749.GC11867@atlas>
References: <20200319090537.5613-1-gorcunov@gmail.com>
 <20200319090537.5613-12-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200319090537.5613-12-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v13 11/11] box/journal: redesign
	journal operations
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

* Cyrill Gorcunov <gorcunov@gmail.com> [20/03/19 12:12]:
> --- a/src/box/wal.c
> +++ b/src/box/wal.c
> @@ -32,6 +32,7 @@
>  
>  #include "vclock.h"
>  #include "fiber.h"
> +#include "txn.h"

Please try to avoid including txn.h here.

You can do it, I'm pretty sure.

>  #include "fio.h"
>  #include "errinj.h"
>  #include "error.h"
> @@ -60,11 +61,17 @@ const char *wal_mode_STRS[] = { "none", "write", "fsync", NULL };
>  

-- 
Konstantin Osipov, Moscow, Russia