From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A8556469719 for ; Thu, 19 Mar 2020 10:19:22 +0300 (MSK) Received: by mail-lj1-f196.google.com with SMTP id w4so1203789lji.11 for ; Thu, 19 Mar 2020 00:19:22 -0700 (PDT) Date: Thu, 19 Mar 2020 10:19:20 +0300 From: Konstantin Osipov Message-ID: <20200319071920.GA3227@atlas> References: <20191114115020.21091-1-maria.khaydich@tarantool.org> <1583942274.319390956@f377.i.mail.ru> <20200312132931.GA30900@atlas> <1584041112.66796082@f172.i.mail.ru> <20200312200024.GA11476@atlas> <20200318222635.GG6392@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200318222635.GG6392@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent function List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org * Igor Munkin [20/03/19 10:08]: > I guess the problem have to be fixed anyway. > > However you might suggest another fix for the issue? There are several > other ways to indicate whether box is configured, e.g. introduce the > specific value to the box table. What do you think? Why not set a lua variable *from* C instead of calling from Lua *into* C each time? I mean, this is an obvious optimization, but it is only worth it if there is a measurable slowdown (which I suspect there is, at least a couple of %, but even a couple of % IMHO justify it). > I see for now box.cfg call as not the one performance critical, but I > might be missing something you see. > > It would be great if you detailed a bit your proposal regarding the fix > and its benchmarks. -- Konstantin Osipov, Moscow, Russia