From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0B123469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 18 Mar 2020 16:58:17 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id w1so27177952ljh.5
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 18 Mar 2020 06:58:17 -0700 (PDT)
Date: Wed, 18 Mar 2020 16:58:15 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200318135815.GB5014@atlas>
References: <20200305122943.7324-1-gorcunov@gmail.com>
 <20200305122943.7324-5-gorcunov@gmail.com>
 <20200306213003.GD8140@atlas> <20200318123834.GS27301@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200318123834.GS27301@uranus>
Subject: Re: [Tarantool-patches] [PATCH 04/10] box/txn: move setup of txn
	start to txn_prepare
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

* Cyrill Gorcunov <gorcunov@gmail.com> [20/03/18 15:42]:
> On Sat, Mar 07, 2020 at 12:30:03AM +0300, Konstantin Osipov wrote:
> > > +
> > > +	/*
> > > +	 * It is important to set start transaction
> > > +	 * time at the last moment, when everything
> > > +	 * is ready to initiate commit procedure,
> > > +	 * just to be more precise in timings to
> > > +	 * detect long WAL writes.
> > > +	 */
> > 
> > I think this comment is misleading. There are no yields
> > between start of txn_prepare() and end. There may appear yields
> > when vinyl lock manager is more smart, but there are no yields
> > now. So ev_monotonic_now returns exactly the same value regardless 
> > of where you call it.
> 
> Kostya, I happen to miss this comment. Look, as far as I understand
> this is not about yields, but this timing is used to detect if the
> write itself takes too long time.

ev time is only updated once per event loop cycle, so as long as
you don't yield, your time is the same.


-- 
Konstantin Osipov, Moscow, Russia