From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 63A4C469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 18 Mar 2020 01:52:56 +0300 (MSK)
Date: Wed, 18 Mar 2020 01:46:38 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200317224638.GD6392@tarantool.org>
References: <cover.1580917791.git.imun@tarantool.org>
 <20200226224509.wunwgszrilnnmykf@tkn_work_nb>
 <20200227104840.GO404@tarantool.org>
 <20200227113535.kbkqmbxikllvk2bz@tkn_work_nb>
 <20200303161712.GY404@tarantool.org>
 <20200303223945.rsj6vm3h5asf63xn@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200303223945.rsj6vm3h5asf63xn@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH v2 luajit 0/3] Introduce gdb
	extension for LuaJIT
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Sasha,

On 04.03.20, Alexander Turenko wrote:
> I don't think that it worth to do in-depth review from my side. But I
> tried the extension, it works and gives output that I can interpret. It
> also has the documentation that is available using gdb's built-in help
> command. It is nice, thanks, Igor!
> 
> So the patchset LGTM. CCed Kirill.
> 
> Igor, please, file an issue for the further activity: we should ship the
> tool in our packages (possibly tarantool-dev/devel) in paths, where gdb
> will able to catch it automatically.

See #4808[1] for the further enhancements I proposed for the extension.

> 
> WBR, Alexander Turenko.
> 

<snipped>

[1]: https://github.com/tarantool/tarantool/issues/4808

-- 
Best regards,
IM