From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 89A3D469719 for ; Tue, 17 Mar 2020 10:37:36 +0300 (MSK) Date: Tue, 17 Mar 2020 10:37:35 +0300 From: Kirill Yukhin Message-ID: <20200317073735.eayqduole2eijh3j@tarantool.org> References: <42037456891c91be0109634ff50505b054f6eac8.1583511306.git.imun@tarantool.org> <20200317073005.waqfekq4ch5na3pg@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200317073005.waqfekq4ch5na3pg@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2] build: disable LUAJIT_ENABLE_PAIRSMM List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy On 17 мар 10:30, Kirill Yukhin wrote: > Hello, > > On 06 мар 19:28, Igor Munkin wrote: > > Since this build flag has been removed as a result of reverting the > > tarantool/luajit@d4e985a, its definition in the corresponding Tarantool > > cmake file is irrelevant. > > > > Furthermore, considering the breakage faced in #4770 the following tests > > are introduced: > > * the check whether space __pairs metamethod is set to space.pairs to > > create a Lua Fun iterator that handles __pairs manually underneath. > > * the check whether pairs builtin behaviour doesn't change when __pairs > > is set e.g. on space object. > > > > Follow-up #4560 > > Closes #4770 > > > > Signed-off-by: Igor Munkin > > LGTM. > Checked into master, 2.3 and 2.2. Checked into 1.10 as well. -- Regards, Kirill Yukhin