From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CDC16469719 for ; Tue, 17 Mar 2020 01:52:24 +0300 (MSK) Date: Tue, 17 Mar 2020 01:46:07 +0300 From: Igor Munkin Message-ID: <20200316224607.GB6392@tarantool.org> References: <42037456891c91be0109634ff50505b054f6eac8.1583511306.git.imun@tarantool.org> <20200306174130.GE404@tarantool.org> <155576cb-03e0-d83d-ac76-62d8f9c7bf0c@tarantool.org> <20200316101251.GA6392@tarantool.org> <5dab058a-fdb2-7981-b2b3-6969c850b06f@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5dab058a-fdb2-7981-b2b3-6969c850b06f@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2] build: disable LUAJIT_ENABLE_PAIRSMM List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Vlad, Thanks for your review. On 16.03.20, Vladislav Shpilevoy wrote: > > diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.result b/test/box/gh-4770-broken-pairs-for-space-objects.result > > index 3ac5995c2..c678714ee 100644 > > --- a/test/box/gh-4770-broken-pairs-for-space-objects.result > > +++ b/test/box/gh-4770-broken-pairs-for-space-objects.result > > @@ -1,14 +1,7 @@ > > -- test-run result file version 2 > > -env = require('test_run') > > +test_run = require('test_run').new() > > Seems like you don't need 'test_run' object either. Fixed, squashed, force-pushed to the branch. Diff is below: ================================================================================ diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.result b/test/box/gh-4770-broken-pairs-for-space-objects.result index c678714ee..6ab778d1a 100644 --- a/test/box/gh-4770-broken-pairs-for-space-objects.result +++ b/test/box/gh-4770-broken-pairs-for-space-objects.result @@ -1,8 +1,4 @@ -- test-run result file version 2 -test_run = require('test_run').new() - | --- - | ... - -- -- gh-4770: Iteration through space with Lua builtin pairs routine -- diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.test.lua b/test/box/gh-4770-broken-pairs-for-space-objects.test.lua index a1ba1eeab..8c36bd305 100644 --- a/test/box/gh-4770-broken-pairs-for-space-objects.test.lua +++ b/test/box/gh-4770-broken-pairs-for-space-objects.test.lua @@ -1,5 +1,3 @@ -test_run = require('test_run').new() - -- -- gh-4770: Iteration through space with Lua builtin pairs routine -- ================================================================================ > > But ok, LGTM. -- Best regards, IM