From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 6D3EE469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 17 Mar 2020 01:31:57 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id g12so20598010ljj.3
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 16 Mar 2020 15:31:57 -0700 (PDT)
Date: Tue, 17 Mar 2020 01:31:54 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200316223154.GF27301@uranus>
References: <7720185c4456a63f0d31bfbe11cdb101e864a3c4.1584284911.git.v.shpilevoy@tarantool.org>
 <20200316071927.GZ27301@uranus>
 <bd6ffe97-2084-9205-e782-c529b12c7f9d@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bd6ffe97-2084-9205-e782-c529b12c7f9d@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] fiber: extend max fiber name
	length to 255
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Mon, Mar 16, 2020 at 11:28:46PM +0100, Vladislav Shpilevoy wrote:
> Hi! Thanks for the review!
> 
> > Thank, Vlad! I like the patch. There is only one concern I have: for
> > some reason we has been defining faiber name as
> > 
> > char name[FIBER_NAME_MAX + 1];
> > 
> > where FIBER_NAME_MAX = 32 and finally this expands to "char name[33];"
> > I'm too lazy to find who exactly introduced this but it is bloody
> > wrong: compiler alings members to eliminate data access penalty, thus
> > _actually_ it will be defined as 8 multilier, ie 40 bytes.
> > 
> > Thus, if you don't mind I propose make FIBER_NAME_INLINE = 40
> > *including* string terminating zero.
> > 
> > Actually we can make it on top then. Up to you. Anyway
> > 
> > Reviewed-by: Cyrill Gorcunov <gorcunov@gmail.com>
> 
> Yes, good point.
> 
> Here is diff. The whole patch is in the bottom.

Thanks a huge, Vlad! My review tag remains.