From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CF9BF469719 for ; Mon, 16 Mar 2020 23:31:29 +0300 (MSK) Received: by mail-lj1-f194.google.com with SMTP id w4so5538099lji.11 for ; Mon, 16 Mar 2020 13:31:29 -0700 (PDT) Date: Mon, 16 Mar 2020 23:31:26 +0300 From: Konstantin Osipov Message-ID: <20200316203126.GA14539@atlas> References: <20200305113600.65203-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200305113600.65203-1-sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] vclock: refactor vclock map to use type uint32_t List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org * Serge Petrenko [20/03/05 14:36]: > We're using an unsigned int to hold vclock map, but there is no > guarantee that unsigned int will be 4 bytes in size to fit all the 32 > vclock components. So use uint32_t instead. I think there is a bunch of functions that still use unsigned to pass the vclock value around. Besides, if you work on a fix like that, it's best to use a typedef right away, so that it's easy to change to uint64t or 128 bit integer in the future. > No issue, discussed in scope of > https://github.com/tarantool/tarantool/issues/4739 > Branch: https://github.com/tarantool/tarantool/tree/sp/vclock-map-refactor -- Konstantin Osipov, Moscow, Russia