From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 575C0469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 16 Mar 2020 19:08:43 +0300 (MSK)
Date: Mon, 16 Mar 2020 16:08:42 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200316160842.GG14628@tarantool.org>
References: <cover.1581940899.git.k.sosnin@tarantool.org>
 <80558927f63a1ad49a4b7c699bfff0bedd727a11.1581940900.git.k.sosnin@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <80558927f63a1ad49a4b7c699bfff0bedd727a11.1581940900.git.k.sosnin@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 3/4] box: provide a user friendly
 frontend for accessing session settings
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

On 17 Feb 15:12, Chris Sosnin wrote:
> - space_object:update() is hard to use for configuring session settings,
> so we provide box.session.setting table, which can be used in a much more
> native way.
> 
> - Prior to this patch sql settings were not accessible before box.cfg()
> call, even though these flags can be set right after session creation.
> 
> Part of #4711
> ---

tarantool> box.session.settings.sql_vdbe_debug
---
- false
...

tarantool> box.session.settings.sql_vdbe_debug = true
---
...

tarantool> box.session.settings.sql_vdbe_debug
---
- true
...

tarantool> box.execute("select 1")
---
- metadata:
  - name: '1'
    type: integer
  rows:
  - [1]
...

Looks inconsistent. Can we use instead of :set() method simple
table value assignment? Otherwise accessing row table values
should be disallowed. Same concerns :get() method. Why ever
anyone should bother with :get() when one can access table value
via simple indexing?