From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7D37E469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 16 Mar 2020 16:19:08 +0300 (MSK)
Date: Mon, 16 Mar 2020 13:19:07 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200316131907.GD14628@tarantool.org>
References: <cover.1581790002.git.v.shpilevoy@tarantool.org>
 <a986784a1b577cde5d64caa59a4a91613f37144d.1581790002.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a986784a1b577cde5d64caa59a4a91613f37144d.1581790002.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/2] tuple: make box.tuple.is()
	public
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: babinoleg@mail.ru, tarantool-patches@dev.tarantool.org

On 15 Feb 19:08, Vladislav Shpilevoy wrote:
> In #4684 it was found that box.tuple.* contained some private
> functions: bless(), encode(), and is().
> 
> Bless() and encode() didn't make any sense for a user, so they
> were hidden into box.internal.tuple.*.
> 
> But box.tuple.is() is actually a useful thing. It is harnessed in
> the tests a lot, and is likely to be already used by customers,
> because it is available in box.tuple.* for a long time. It is a
> matter of time when someone will open a doc ticket saying that
> box.tuple.is() is not documented.
> 
> So the patch makes it legally public.
> 
> Follow-up #4684
> 
> @TarantoolBot document
> Title: box.tuple.is()
> A function to check whether a given object is a tuple cdata
> object. Returns true or false. Never raises nor returns an error.

LGTM