From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0E984469719 for ; Mon, 16 Mar 2020 16:02:43 +0300 (MSK) Date: Mon, 16 Mar 2020 13:02:42 +0000 From: Nikita Pettik Message-ID: <20200316130242.GB14628@tarantool.org> References: <073c9b48376b0d53df7cc826a8774a7f4f35f087.1584293997.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <073c9b48376b0d53df7cc826a8774a7f4f35f087.1584293997.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/1] sql: trust column duplicate check to box List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On 15 Mar 18:41, Vladislav Shpilevoy wrote: > CREATE TABLE used to check column name duplicates before going to > box. But it is not necessary, because the same check is done by > box. LGTM. Pushed to master as obvious. > --- > Branch: http://github.com/tarantool/tarantool/tree/gerold103/drop-column-duplicate-check-from-sql > > src/box/sql/build.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/src/box/sql/build.c b/src/box/sql/build.c > index fbfd05cbf..7511fad37 100644 > --- a/src/box/sql/build.c > +++ b/src/box/sql/build.c > @@ -324,13 +324,6 @@ sqlAddColumn(Parse * pParse, Token * pName, struct type_def *type_def) > pParse->is_aborted = true; > return; > } > - for (uint32_t i = 0; i < def->field_count; i++) { > - if (strcmp(z, def->fields[i].name) == 0) { > - diag_set(ClientError, ER_SPACE_FIELD_IS_DUPLICATE, z); > - pParse->is_aborted = true; > - return; > - } > - } > struct field_def *column_def = &def->fields[def->field_count]; > memcpy(column_def, &field_def_default, sizeof(field_def_default)); > column_def->name = z; > -- > 2.21.1 (Apple Git-122.3) >