From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 39FD3469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 16 Mar 2020 13:19:11 +0300 (MSK)
Date: Mon, 16 Mar 2020 13:12:51 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200316101251.GA6392@tarantool.org>
References: <42037456891c91be0109634ff50505b054f6eac8.1583511306.git.imun@tarantool.org>
 <20200306174130.GE404@tarantool.org>
 <155576cb-03e0-d83d-ac76-62d8f9c7bf0c@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <155576cb-03e0-d83d-ac76-62d8f9c7bf0c@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2] build: disable
	LUAJIT_ENABLE_PAIRSMM
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Vlad,

On 12.03.20, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> 
> > --- /dev/null
> > +++ b/test/box/gh-4770-broken-pairs-for-space-objects.result
> > @@ -0,0 +1,41 @@
> > +-- test-run result file version 2
> > +env = require('test_run')
> > + | ---
> > + | ...
> > +test_run = env.new()
> > + | ---
> > + | ...
> > +test_run:cmd("push filter 'table: .*' to 'table: <address>'")
> 
> Why do you need the filter? There is nothing to filter out.
> You never print any 'table: .*' strings.
> 

Thanks for your comment! I overlooked this line when copy-pasting the
preambule from box/misc.test.lua and I agree the filter is excess.

Fixed, squashed, force-pushed to the branch. Diff is below:

================================================================================

diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.result b/test/box/gh-4770-broken-pairs-for-space-objects.result
index 3ac5995c2..c678714ee 100644
--- a/test/box/gh-4770-broken-pairs-for-space-objects.result
+++ b/test/box/gh-4770-broken-pairs-for-space-objects.result
@@ -1,14 +1,7 @@
 -- test-run result file version 2
-env = require('test_run')
+test_run = require('test_run').new()
  | ---
  | ...
-test_run = env.new()
- | ---
- | ...
-test_run:cmd("push filter 'table: .*' to 'table: <address>'")
- | ---
- | - true
- | ...
 
 --
 -- gh-4770: Iteration through space with Lua builtin pairs routine
diff --git a/test/box/gh-4770-broken-pairs-for-space-objects.test.lua b/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
index 315352b15..a1ba1eeab 100644
--- a/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
+++ b/test/box/gh-4770-broken-pairs-for-space-objects.test.lua
@@ -1,6 +1,4 @@
-env = require('test_run')
-test_run = env.new()
-test_run:cmd("push filter 'table: .*' to 'table: <address>'")
+test_run = require('test_run').new()
 
 --
 -- gh-4770: Iteration through space with Lua builtin pairs routine

================================================================================

-- 
Best regards,
IM