From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B7C51469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 16 Mar 2020 12:42:15 +0300 (MSK)
Date: Mon, 16 Mar 2020 12:42:21 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200316094221.ff6p6y4b3ip6k3rt@tkn_work_nb>
References: <20200219064411.37542-1-arkholga@tarantool.org>
 <20200304153127.uhssittpe3obggq3@tkn_work_nb>
 <baac6b6c-5057-8549-025a-3568e988e96a@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <baac6b6c-5057-8549-025a-3568e988e96a@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] test: use grep_log in tests
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Tue, Mar 10, 2020 at 02:35:09PM +0300, Olga Arkhangelskaia wrote:
> Hi, Alexander!
> 
> I have fixed things you have pointed out and pushed it to branch
> 
> https://github.com/tarantool/tarantool/tree/OKriw/refactoring_of_panic_on_broken_lsn.test.lua

Pushed to master, 2.3, 2.2 and 1.10.

Found https://github.com/tarantool/tarantool/issues/4806 while testing
the change before push (looks unrelated to the change, so pushed
anyway).

CCed Kirill.

> 
> The branch can not be tested without
> 
> https://github.com/tarantool/test-run/tree/OKriw/gh-196-Extend-grep_log-for-crashed-instances

test-run part was pushed in
https://lists.tarantool.org/pipermail/tarantool-patches/2020-March/014786.html

> > > test: use grep_log in tests
> >
> > Nit: I would make the commit header a bit more certain and point the
> > test name right here.
> 
> [PATCH] tests: use grep_log opt.filename in panic_on_broken_lsn

A bit changed: used 'test' prefix, removed 'opt'.