From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AFB00469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 16 Mar 2020 12:18:36 +0300 (MSK)
Date: Mon, 16 Mar 2020 12:18:42 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200316091842.t6qhaehvn7mvw7nc@tkn_work_nb>
References: <20200218180101.37385-1-arkholga@tarantool.org>
 <20200304135133.hnj3wdsnizsbo76l@tkn_work_nb>
 <d3615520-de89-77f2-6b96-32e228412a3b@tarantool.org>
 <20200316091553.4hbyadvcubrpdzk4@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200316091553.4hbyadvcubrpdzk4@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH] test_run: add path option to
	grep_log
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

CCed the mail list.

----

(Sorry, forgot to send it at March, 12.)

Pushed to test-run with changes in the commit message (see below).
Updated the submodule in tarantool on the following branches: master,
2.3, 2.2 and 1.10.

CCed Kirill.

WBR, Alexander Turenko.

> > > While using grep_log it is useful to have a possibility to go through crashed
> > Please, keep a commit message body within 72 symbols.
> 
> [PATCH] test_run: add filename option to grep_log

Removed 'test_run:' prefix. It is convenient to determine a repository
in tarantool-patches mailing list, but have no much sense in the commit
itself (because it is already in test-run repository).

I suggest to use '--subject-prefix' option for 'git format-patch' when
preparing changes for a repository other then tarantool.

> 
> To search custom logs filename option of grep_log can be used.

Expanded the description a bit:

 | The option can be used when it is not possible to grab 'box.cfg.log'
 | value from a tarantool instance: say, when the instance is stopped or
 | crashed.

> Usage: grep_log(self, node, waht, bytes, {filename = XXX})

Fixed typo: waht.

I rewrote it a bit to avoid confusion with self / colon and so:

 | Usage:
 |
 |  | local test_run = require('test_run').new()
 |  | test_run:grep_log(node, what, bytes, {filename = <...>})

> 
> Closes #196
> 
> @Changelog
> Search custom log grep_log(self, node, waht, bytes, {filename = XXX})

Removed from the commit message. It should be in a email (at least for
tarantool), but should not be part of a commit message.