From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5026C469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 12 Mar 2020 16:29:38 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id f10so6421392ljn.6
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 12 Mar 2020 06:29:38 -0700 (PDT)
Date: Thu, 12 Mar 2020 16:29:31 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200312132931.GA30900@atlas>
References: <20191114115020.21091-1-maria.khaydich@tarantool.org>
 <1579344991.266039392@f319.i.mail.ru>
 <20200220175124.pwj24lx3jz4w6zcm@tkn_work_nb>
 <1583942274.319390956@f377.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1583942274.319390956@f377.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH 1/2] box: make box.cfg idempotent
 function
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Maria Khaydich <maria.khaydich@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

* Maria Khaydich <maria.khaydich@tarantool.org> [20/03/11 19:02]:
> 
> Calling box.cfg{} more than once does not normally cause any errors
> (even though it might not have any effect). In contrast, assigning
> it to some variable and then using it after the box was configured
> caused an error since the method was overwritten by the initial call
> of <load_cfg>.
>  
> The patch fixes this issue making box.cfg behave consistently in both
> scenarios and is a follow-up for box: make box.execute idempotent function.

Did you benchmark it?

>  
> Follow-up #4231
> ---
> Issue:
> https://github.com/tarantool/tarantool/issues/4231  
> Branch:
> https://github.com/tarantool/tarantool/compare/eljashm/gh-4231-box.execute-immutable-function  

-- 
Konstantin Osipov, Moscow, Russia