From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com
 [209.85.167.67])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 71EF1469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 12 Mar 2020 15:18:10 +0300 (MSK)
Received: by mail-lf1-f67.google.com with SMTP id q10so4605999lfo.8
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 12 Mar 2020 05:18:10 -0700 (PDT)
Date: Thu, 12 Mar 2020 15:18:06 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200312121806.GO27301@uranus>
References: <20200302201227.31785-1-gorcunov@gmail.com>
 <20200312115842.q2gwcdkvolghalvu@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200312115842.q2gwcdkvolghalvu@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH 0/7] popen: various fixes and a test
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Thu, Mar 12, 2020 at 02:58:42PM +0300, Alexander Turenko wrote:
> I don't have objections anymore. LGTM.
> 
> The actual version is on the branch gorcunov/gh-4031-popen-fixup-5.
> 
> I'm a bit afraid that we don't test POPEN_FLAG_SETSID. However the code
> itself looks right and we maybe will return to this later.
> 
> NB: We'll need to test two things to verify setsid():
> 
> * The situation when a controlling terminal died. Maybe use screen /
>   tmux here?
> * The ability to kill a spawned process group at whole (but w/o
>   tarantool itself). Say, "sh -c 'foo | bar'".
> 
> Pushed also gorcunov/gh-4031-popen-fixup-5-full-ci to verify on all
> targets (just in case). See results here:
> https://gitlab.com/tarantool/tarantool/pipelines/125648893 (they are now
> in fly).

Thanks a huge, Sasha! I think we continue fixing/extending popen engine.