From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 067FB469719 for ; Thu, 12 Mar 2020 14:03:48 +0300 (MSK) Date: Thu, 12 Mar 2020 14:03:52 +0300 From: Alexander Turenko Message-ID: <20200312110352.gmsgjhbx6y7hff4a@tkn_work_nb> References: <20200221111935.gw7rj7vlhc2jquam@tkn_work_nb> <1583924700.513372502@f460.i.mail.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1583924700.513372502@f460.i.mail.ru> Subject: Re: [Tarantool-patches] [PATCH v1] test: add more tests to packaging testing List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Tikhonov Cc: Oleg Piskunov , tarantool-patches@dev.tarantool.org > >> # For tests > >> -%if (0%{?fedora} >= 22 || 0%{?rhel} == 7) > >> -BuildRequires: python >= 2.7 > >> -BuildRequires: python-six >= 1.9.0 > >> -BuildRequires: python-gevent >= 1.0 > >> -BuildRequires: python-yaml >= 3.0.9 > >> -%endif > >> %if (0%{?fedora} >= 31 || 0%{?rhel} >= 8) > >> BuildRequires: python2 >= 2.7 > >> BuildRequires: python2-six >= 1.9.0 > >> BuildRequires: python2-gevent >= 1.0 > >> BuildRequires: python2-yaml >= 3.0.9 > >> +%else > >> +%if (0%{?rhel} != 6) > > > >Don't understood: what was actually changed? We have Fedora 28-31 and > >CentOS 6-8 in testing / deploying. > Please check the next comment. > > > > > >> +BuildRequires: python >= 2.7 > >> +BuildRequires: python-six >= 1.9.0 > >> +BuildRequires: python-gevent >= 1.0 > >> +BuildRequires: python-yaml >= 3.0.9 > >> +%endif > >> %endif > >> > In the current change and one before, the check of the versions added. Before it > was that only Fedora and CentOS installed the python packages for the testing. > As after the change all OSs (except CentOS 6) will have it installed except > Fedora since 31 version and CentOS since 8 version will have python2. After I discussed it voicely with Alexander I got what was changed. Fedora 31 and CentOS 8 installs both python-foo and python2-foo dependencies, while python-foo is actually alias for python3-foo. It does not fail the build, but is not used. I'm okay to remove unused Python 3 deps, but let's add a comment here (right in the spec): it is not obvious, you see. > >> %check > >> -%if (0%{?fedora} >= 22 || 0%{?rhel} >= 7) > >> # https://github.com/tarantool/tarantool/issues/1227 > >> echo "self.skip = True" > ./test/app/socket.skipcond > >> # https://github.com/tarantool/tarantool/issues/1322 > >> echo "self.skip = True" > ./test/app/digest.skipcond > > > >Those two issues now closed. Maybe it is time to enable those tests? > Sure, I'll add separate commit into the current patch set. As I see on the branch (avtikhon/gh-4599-packages-testing-full-ci), you removed it right in this commit. Anyway, it is okay for me. > >> -cd test && ./test-run.py --force -j 1 unit/ app/ app-tap/ box/ box-tap/ engine/ vinyl/ > >> +%if (0%{?rhel} != 6) > >> + TEST_RUN_EXCLUDE='replication/' make test-force > >> %endif > > > >Flaky fails rate will increase on Travis-CI if we'll enable > >parallelization. Either discard this change or enable it only for > >gitlab-ci. > Added mark 'IS_TRAVIS' to be changed by packpack on run. Commented in https://github.com/packpack/packpack/pull/116