From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 85479469719 for ; Thu, 12 Mar 2020 13:38:04 +0300 (MSK) Received: by mail-lj1-f196.google.com with SMTP id f10so5803783ljn.6 for ; Thu, 12 Mar 2020 03:38:04 -0700 (PDT) Date: Thu, 12 Mar 2020 13:38:00 +0300 From: Cyrill Gorcunov Message-ID: <20200312103800.GN27301@uranus> References: <20200302201227.31785-1-gorcunov@gmail.com> <20200302201227.31785-8-gorcunov@gmail.com> <20200311202213.pugz24653u7zlk4f@tkn_work_nb> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200311202213.pugz24653u7zlk4f@tkn_work_nb> Subject: [Tarantool-patches] [PATCH v5 7/7] test/unit: add popen test List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tml Basic test for popen engine Signed-off-by: Cyrill Gorcunov --- Sasha, thanks a huge for all your comments! I've merged your changes into the series. branch gorcunov/gh-4031-popen-fixup-5 test/unit/CMakeLists.txt | 3 + test/unit/popen.c | 258 +++++++++++++++++++++++++++++++++++++++ test/unit/popen.result | 31 +++++ 3 files changed, 292 insertions(+) create mode 100644 test/unit/popen.c create mode 100644 test/unit/popen.result diff --git a/test/unit/CMakeLists.txt b/test/unit/CMakeLists.txt index c037ac539..4ac08de8d 100644 --- a/test/unit/CMakeLists.txt +++ b/test/unit/CMakeLists.txt @@ -240,3 +240,6 @@ target_link_libraries(swim_errinj.test unit swim) add_executable(merger.test merger.test.c) target_link_libraries(merger.test unit core box) + +add_executable(popen.test popen.c) +target_link_libraries(popen.test misc unit core) diff --git a/test/unit/popen.c b/test/unit/popen.c new file mode 100644 index 000000000..a40ca514c --- /dev/null +++ b/test/unit/popen.c @@ -0,0 +1,258 @@ +#include +#include + +#include "trivia/util.h" +#include "unit.h" + +#include "coio.h" +#include "coio_task.h" +#include "memory.h" +#include "fiber.h" +#include "popen.h" +#include "say.h" + +#define TEST_POPEN_COMMON_FLAGS \ + (POPEN_FLAG_SETSID | \ + POPEN_FLAG_SHELL | \ + POPEN_FLAG_RESTORE_SIGNALS) + +/** + * A real return value of main_f(), see a comment in swim.c. + */ +static int test_result = 1; + +static int +wait_exit(struct popen_handle *handle, int *state, int *exit_code) +{ + for (;;) { + if (popen_state(handle, state, exit_code)) + return -1; + if (*state == POPEN_STATE_EXITED || + *state == POPEN_STATE_SIGNALED) + break; + fiber_sleep(0.1); + } + return 0; +} + +static void +popen_write_exit(void) +{ + struct popen_handle *handle; + char *child_argv[] = { + "/bin/sh", "-c", + "prompt=''; read -n 5 prompt; echo $prompt", + NULL, + }; + + const char data[] = "12345"; + int state, exit_code; + + struct popen_opts opts = { + .argv = child_argv, + .nr_argv = lengthof(child_argv), + .env = NULL, + .flags = + POPEN_FLAG_FD_STDIN | + POPEN_FLAG_FD_STDOUT | + POPEN_FLAG_FD_STDERR | + TEST_POPEN_COMMON_FLAGS, + }; + int rc; + + plan(7); + header(); + + handle = popen_new(&opts); + ok(handle != NULL, "popen_new"); + if (handle == NULL) + goto out; + + rc = popen_state(handle, &state, &exit_code); + ok(rc == 0, "popen_state"); + + ok(state == POPEN_STATE_ALIVE, "state %s", + popen_state_str(state)); + + rc = popen_write_timeout(handle, (void *)data, + (int)strlen(data), + POPEN_FLAG_FD_STDOUT, 180); + ok(rc == -1, "write flag check"); + + rc = popen_write_timeout(handle, (void *)data, + (int)strlen(data), + POPEN_FLAG_FD_STDIN, 180); + ok(rc == (int)strlen(data), "write to pipe"); + if (rc != (int)strlen(data)) + goto out_kill; + + rc = wait_exit(handle, &state, &exit_code); + if (rc) { + ok(false, "child wait"); + goto out_kill; + } + + ok(state == POPEN_STATE_EXITED, "child exited"); + +out_kill: + rc = popen_delete(handle); + ok(rc == 0, "popen_delete"); + +out: + footer(); + check_plan(); +} + +static void +popen_read_exit(void) +{ + struct popen_handle *handle; + char *child_argv[] = { + "/bin/sh", "-c", + "echo 1 2 3 4 5", + NULL, + }; + + int state, exit_code; + char data[32] = { }; + + struct popen_opts opts = { + .argv = child_argv, + .nr_argv = lengthof(child_argv), + .env = NULL, + .flags = + POPEN_FLAG_FD_STDIN | + POPEN_FLAG_FD_STDOUT | + POPEN_FLAG_FD_STDERR | + TEST_POPEN_COMMON_FLAGS, + }; + int rc; + + plan(5); + header(); + + handle = popen_new(&opts); + ok(handle != NULL, "popen_new"); + if (handle == NULL) + goto out; + + rc = wait_exit(handle, &state, &exit_code); + if (rc) { + ok(false, "child wait"); + goto out_kill; + } + ok(state == POPEN_STATE_EXITED, "child exited"); + + rc = popen_read_timeout(handle, data, sizeof(data), + POPEN_FLAG_FD_STDIN, 180); + ok(rc == -1, "read flag check"); + + rc = popen_read_timeout(handle, data, sizeof(data), + POPEN_FLAG_FD_STDOUT, 180); + ok(rc >= 9 && !strncmp(data, "1 2 3 4 5", 9), "read from pipe"); + +out_kill: + rc = popen_delete(handle); + ok(rc == 0, "popen_delete"); + +out: + footer(); + check_plan(); +} + +static void +popen_kill(void) +{ + struct popen_handle *handle; + char *child_argv[] = { + "/bin/sh", "-c", + "while [ 1 ]; do sleep 10; done", + NULL, + }; + + int state, exit_code; + + struct popen_opts opts = { + .argv = child_argv, + .nr_argv = lengthof(child_argv), + .env = NULL, + .flags = + POPEN_FLAG_FD_STDIN | + POPEN_FLAG_FD_STDOUT | + POPEN_FLAG_FD_STDERR | + TEST_POPEN_COMMON_FLAGS, + }; + int rc; + + plan(4); + header(); + + handle = popen_new(&opts); + ok(handle != NULL, "popen_new"); + if (handle == NULL) + goto out; + + rc = popen_send_signal(handle, SIGTERM); + ok(rc == 0, "popen_send_signal"); + if (rc != 0) + goto out_kill; + + rc = wait_exit(handle, &state, &exit_code); + if (rc) { + ok(false, "child wait"); + goto out_kill; + } + ok(state == POPEN_STATE_SIGNALED, "child terminated"); + +out_kill: + rc = popen_delete(handle); + ok(rc == 0, "popen_delete"); + +out: + footer(); + check_plan(); +} + +static int +main_f(va_list ap) +{ + plan(3); + header(); + + popen_write_exit(); + popen_read_exit(); + popen_kill(); + + ev_break(loop(), EVBREAK_ALL); + + footer(); + test_result = check_plan(); + + return 0; +} + +int +main(int argc, char *argv[]) +{ + //say_logger_init(NULL, S_DEBUG, 0, "plain", 0); + memory_init(); + + fiber_init(fiber_c_invoke); + popen_init(); + coio_init(); + coio_enable(); + + if (!loop()) + panic("%s", "can't init event loop"); + + struct fiber *test = fiber_new("main", main_f); + fiber_wakeup(test); + + ev_now_update(loop()); + ev_run(loop(), 0); + popen_free(); + fiber_free(); + memory_free(); + + return test_result; +} diff --git a/test/unit/popen.result b/test/unit/popen.result new file mode 100644 index 000000000..d7894d1db --- /dev/null +++ b/test/unit/popen.result @@ -0,0 +1,31 @@ +1..3 + *** main_f *** + 1..7 + *** popen_write_exit *** + ok 1 - popen_new + ok 2 - popen_state + ok 3 - state alive + ok 4 - write flag check + ok 5 - write to pipe + ok 6 - child exited + ok 7 - popen_delete + *** popen_write_exit: done *** +ok 1 - subtests + 1..5 + *** popen_read_exit *** + ok 1 - popen_new + ok 2 - child exited + ok 3 - read flag check + ok 4 - read from pipe + ok 5 - popen_delete + *** popen_read_exit: done *** +ok 2 - subtests + 1..4 + *** popen_kill *** + ok 1 - popen_new + ok 2 - popen_send_signal + ok 3 - child terminated + ok 4 - popen_delete + *** popen_kill: done *** +ok 3 - subtests + *** main_f: done *** -- 2.20.1