From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 84EC6469719 for ; Tue, 10 Mar 2020 16:42:51 +0300 (MSK) Date: Tue, 10 Mar 2020 13:42:50 +0000 From: Nikita Pettik Message-ID: <20200310134250.GB26141@tarantool.org> References: <52f89e63f044680d79f212ac91513c3738b8f1f6.1583689251.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <52f89e63f044680d79f212ac91513c3738b8f1f6.1583689251.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/3] box: fix struct port_tuple.size wrong type in Lua List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On 08 Mar 18:47, Vladislav Shpilevoy wrote: > Original port_tuple in C has 'int size;' field. It was > 'size_t size' in Lua. Since sizeof(size_t) usually is > 8, and sizeof(int) is 4, this was a really bad typo. LGTM (feel free to push out of order as obvious). > --- > src/box/lua/schema.lua | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/box/lua/schema.lua b/src/box/lua/schema.lua > index f537c3cec..aba439ffb 100644 > --- a/src/box/lua/schema.lua > +++ b/src/box/lua/schema.lua > @@ -84,7 +84,7 @@ ffi.cdef[[ > > struct port_tuple { > const struct port_vtab *vtab; > - size_t size; > + int size; > struct port_tuple_entry *first; > struct port_tuple_entry *last; > struct port_tuple_entry first_entry; > -- > 2.21.1 (Apple Git-122.3) >