From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1E693469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 10 Mar 2020 16:34:48 +0300 (MSK)
Date: Tue, 10 Mar 2020 13:34:46 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200310133446.GA26141@tarantool.org>
References: <20200210074712.86876-1-arkholga@tarantool.org>
 <20200210111826.GD1110@tarantool.org>
 <2cbb1677-039b-9f91-cde7-9c06821653eb@tarantool.org>
 <20200211124245.GB5168@tarantool.org>
 <20200218124612.GA67746@tarantool.org>
 <714780e3-1383-62da-94f9-0e90542d47aa@tarantool.org>
 <20200219162843.GA68447@tarantool.org>
 <78db8579-e246-385b-6541-5cc70395be97@tarantool.org>
 <20200304211841.GB9655@tarantool.org>
 <996b64f7-95f8-e8aa-a327-ec63398e12f5@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <996b64f7-95f8-e8aa-a327-ec63398e12f5@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6] memtx: fix out of memory
	handling for rtree
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 10 Mar 14:25, Olga Arkhangelskaia wrote:
> Done.

Pushed to master, 2.3, 2.2 and 1.10. Updated changelogs for
branches correspondingly.
 
> 05.03.2020 0:18, Nikita Pettik пишет:
> > On 03 Mar 14:50, Olga Arkhangelskaia wrote:
> > > Hi Sergey! I need time to check everything!
> > > 
> > > I can not use error injection that exists in memtx_index_extent_reserve(),
> > > 
> > > because it is used  in memtx_space_replace_all_keys ant it is called prior
> > > memtx_rtree_index_reserve() .
> > > 
> > > If we use memtx_index_extent_reserve(), injection we will not reach the
> > > place where error with rtree occures.
> > > 
> > > So to make sure that we fixed the problem we need
> > > memtx_rtree_index_reserve() to fail.
> > > 
> > Since now patch received two acks, it is ready to be pushed.
> > Olga, could you please rebase branch on the top of master (there's several
> > merge conflicts) and provide brief @changelog (a few sentences for casual
> > Tarantool users concerning visible changes this patch introduces)? As soon
> > as it is ready, I'll push it. Thanks.
> >