From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 379C7469719
 for <tarantool-patches@dev.tarantool.org>;
 Sat,  7 Mar 2020 01:04:21 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id r7so3789383ljp.10
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 06 Mar 2020 14:04:21 -0800 (PST)
Date: Sat, 7 Mar 2020 01:04:19 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200306220419.GB6478@atlas>
References: <20200305122943.7324-1-gorcunov@gmail.com>
 <20200305122943.7324-10-gorcunov@gmail.com>
 <20200306213743.GI8140@atlas> <20200306214145.GB27301@uranus>
 <20200306215103.GK8140@atlas> <20200306215755.GC27301@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200306215755.GC27301@uranus>
Subject: Re: [Tarantool-patches] [PATCH 09/10] box/journal:
 journal_entry_new -- drop setting up callbacks
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

* Cyrill Gorcunov <gorcunov@gmail.com> [20/03/07 00:59]:
> To be honest -- I don't know at the moment. This is replication test
> if I understand correctly and I presume these are async calls, but
> not sure yet. What is interesting is that vinyl internally use
> journal entries and calls cbus directly to write the data (again,
> if I understand correctly 'cause I know nothing about vinyl internals)
> and this might be the reason.

it just reuses the wal thread infrastructure, but this is a completely
different code path, not related to your changes at all.

your crash is in txn_complete(), it seems, which is not called for
vinyl vy_log entry at all, there are no callbacks and it uses
cbus_call(), so there is no entry batching either.


-- 
Konstantin Osipov, Moscow, Russia