From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kostja.osipov@gmail.com>
Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com
 [209.85.208.194])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 74736469719
 for <tarantool-patches@dev.tarantool.org>;
 Sat,  7 Mar 2020 00:51:05 +0300 (MSK)
Received: by mail-lj1-f194.google.com with SMTP id 19so953320ljj.7
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 06 Mar 2020 13:51:05 -0800 (PST)
Date: Sat, 7 Mar 2020 00:51:03 +0300
From: Konstantin Osipov <kostja.osipov@gmail.com>
Message-ID: <20200306215103.GK8140@atlas>
References: <20200305122943.7324-1-gorcunov@gmail.com>
 <20200305122943.7324-10-gorcunov@gmail.com>
 <20200306213743.GI8140@atlas> <20200306214145.GB27301@uranus>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200306214145.GB27301@uranus>
Subject: Re: [Tarantool-patches] [PATCH 09/10] box/journal:
 journal_entry_new -- drop setting up callbacks
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

* Cyrill Gorcunov <gorcunov@gmail.com> [20/03/07 00:44]:
> But vinyl test case fails
> 
> 2020-03-07 00:35:51.116 [6494] main/136/applier/unix/:/home/cyrill/sda1 I> subscribed
> 2020-03-07 00:35:51.116 [6494] main/136/applier/unix/:/home/cyrill/sda1 I> remote vclock {1: 782} local vclock {1: 382}
> tarantool: /home/cyrill/sda1/tarantool/tarantool.git/src/box/vy_tx.c:803: void vy_tx_commit(struct vy_tx *, int64_t): Assertion `xm->lsn <= lsn' failed.
> [001] replication/gc.test.lua                         vinyl           

This has to do most likely with out-of-order invocation of the
wakeup callbacks.

Are these sync callbacks or async callbacks?

When a batch of transactions are submitted to wal, they got to be
scheduled to commit in the order of their lsn.

the order gets broken here for some reason. Please find out why.

-- 
Konstantin Osipov, Moscow, Russia