From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 36F60469719 for ; Sat, 7 Mar 2020 00:37:45 +0300 (MSK) Received: by mail-lj1-f195.google.com with SMTP id h18so3709689ljl.13 for ; Fri, 06 Mar 2020 13:37:45 -0800 (PST) Date: Sat, 7 Mar 2020 00:37:43 +0300 From: Konstantin Osipov Message-ID: <20200306213743.GI8140@atlas> References: <20200305122943.7324-1-gorcunov@gmail.com> <20200305122943.7324-10-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200305122943.7324-10-gorcunov@gmail.com> Subject: Re: [Tarantool-patches] [PATCH 09/10] box/journal: journal_entry_new -- drop setting up callbacks List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov Cc: tml * Cyrill Gorcunov [20/03/05 15:32]: > The callbacks gonna be different from sync and async > commits thus lets untangle it from journal_entry_new > interface but setup explicitly. > > I think setting up NULLs for entry is a safe approach > so we can allow us to spend a few cycles. This is a hot path. I don't see much value in this patch, but I don't think it makes much of a difference either way. My preference is to drop this patch, just pass different call backs from different call sites. -- Konstantin Osipov, Moscow, Russia