From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E4013469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  6 Mar 2020 23:39:29 +0300 (MSK)
Date: Fri, 6 Mar 2020 23:39:28 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200306203928.7firki6q54ifyrk4@tkn_work_nb>
References: <20200303161649.62470-1-k.sosnin@tarantool.org>
 <20200305054101.6btvhiglj6olbijv@tarantool.org>
 <20200305084135.GC9655@tarantool.org>
 <20200306172701.sziodfignjz2ix6a@tkn_work_nb>
 <91892E2F-8CEF-4461-9AF5-512016633F8A@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <91892E2F-8CEF-4461-9AF5-512016633F8A@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2] iproto: add an empty body to the
 unprepare response
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

> > Technically there are two ways to extract helpers from a 'core =
> > tarantool' test:
> > 
> > * Add it to, say, test/box/box.lua and to _G.protected_globals.
> > * Add it to a separate Lua file in test/box/lua and to 'lua_libs' field
> >  in test/box/suite.ini. After this you can use `require` for this
> >  module in a test.
> 
> This also seems like a fine solution, if we are to stick to the SOP, I will do this.

It is our process. We should follow it or at least provide strong
reasoning why we shouldn't in a particular case.

> However, I’m not sure whether this patch fixes a bug, it is stated in the code
> that there’s nothing to send in case of unprepare, perhaps it is a feature?

The issue is marked with 'bug' label.

'unprepare' is the only request, which does not contain a body. In
1.6.4-128-gf433f4b0a (see [1]) it was decided to always send a body in a
response and 'unprepare' does not fit this property. It is unexpected
behaviour and it is what we usually call a bug.

[1]: https://github.com/tarantool/tarantool/commit/f433f4b0aeab48be9b5259b6c5065091dbf07553

WBR, Alexander Turenko.