From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1470F469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  6 Mar 2020 20:27:02 +0300 (MSK)
Date: Fri, 6 Mar 2020 20:27:01 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200306172701.sziodfignjz2ix6a@tkn_work_nb>
References: <20200303161649.62470-1-k.sosnin@tarantool.org>
 <20200305054101.6btvhiglj6olbijv@tarantool.org>
 <20200305084135.GC9655@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200305084135.GC9655@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2] iproto: add an empty body to the
 unprepare response
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: v.shpilevoy@tarantool.org, tarantool-patches@dev.tarantool.org

On Thu, Mar 05, 2020 at 08:41:35AM +0000, Nikita Pettik wrote:
> On 05 Mar 08:41, Kirill Yukhin wrote:
> > Hello,
> > 
> > On 03 мар 19:16, Chris Sosnin wrote:
> > > Absence of the body in the unprepare response forces users to perform
> > > additional checks to avoid errors. Adding an empty body fixes this problem.
> > > 
> > > Closes #4769
> > > ---
> > > branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4769-unprepare-response-body
> > > issue: https://github.com/tarantool/tarantool/issues/4769
> > > 
> > > As Nikita suggested, I created box/iproto.test.lua, and basically
> > > inserted wrappers for requests testing from box-py for future usage.
> > 
> > Could you please rename the test to be not so generic?
> > Like box/gh-4769-iproto-unprep-body or whatever.
> 
> Kirill, this test is going to assemble all iproto-related tests
> which don't rely on net.box module. Setting up all preparations
> required for raw iproto communication results in duplicating ~30-40
> lines of code in each test file.

Technically there are two ways to extract helpers from a 'core =
tarantool' test:

* Add it to, say, test/box/box.lua and to _G.protected_globals.
* Add it to a separate Lua file in test/box/lua and to 'lua_libs' field
  in test/box/suite.ini. After this you can use `require` for this
  module in a test.

So technically you're not blocked here. Both ways are available and
don't lead to much code duplication, but the process (SOP) requires to
add a test for a bug to a separate file. (Personally I still don't sure
it is good, but anyway.)

NB: 'receive', not 'recieve'. Very often typo.

WBR, Alexander Turenko.