From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 86161469719 for ; Fri, 6 Mar 2020 18:45:04 +0300 (MSK) Date: Fri, 6 Mar 2020 18:45:03 +0300 From: Kirill Yukhin Message-ID: <20200306154503.mjz5f47p3jyrb3v5@tarantool.org> References: <4ecccbd1294ac024dfc9c05d2d7f74b908e50992.1583442898.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4ecccbd1294ac024dfc9c05d2d7f74b908e50992.1583442898.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/1] test: fix fio.test.lua flakiness List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Hello, On 05 мар 22:15, Vladislav Shpilevoy wrote: > In 89c73e64c071cb7402406bf1eb8d767d4dfe4e6e ("fio: respect > $TMPDIR in fio.tempdir(), when it is set") was added a test > checking that fio.tempdir() returns a path to a folder, stored > by a path specified in $TMPDIR environment variable. > > Check was done by calling Lua returned_path:find(tmpdir_path). > If tmpdir path contained 'special' characters such as '.', it > didn't match, because string.find() takes a regular expression, > not just a string. > > string.startswith() works fine. > > Follow-up #4794 > --- > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-4794-follow-up-test > Issue: https://github.com/tarantool/tarantool/issues/4794 I've checked your patch into master as obvious. -- Regards, Kirill Yukhin