From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 39C10469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  6 Mar 2020 17:32:16 +0300 (MSK)
Date: Fri, 6 Mar 2020 14:32:15 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200306143214.GD12214@tarantool.org>
References: <1581359737.397395198@f221.i.mail.ru>
 <1583253766.42635729@f106.i.mail.ru>
 <2f34a430-731d-069a-8856-8cdbc30e77ab@tarantool.org>
 <1583494456.594178474@f380.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1583494456.594178474@f380.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH] box: sql prepare and execute
 statistics should be reflected in box.stat()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Maria Khaydich <maria.khaydich@tarantool.org>
Cc: tarantool-patches <tarantool-patches@dev.tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On 06 Mar 14:34, Maria Khaydich wrote:
> 
> Thank you for the review. Fixed the comments:
> ----------------------------------------------------------------------
> The patch fixes a bug for the  previous commit when statistics on box.execute
> was collected twice. This happened because sql_prepare_and_execute called
> sql_execute under the hood, so there's no need to do rmean_collect in both
> of them.
>  
> Follow-up #4756
> ---
> Issue:
> https://github.com/tarantool/tarantool/issues/4756  
> Branch:
> https://github.com/tarantool/tarantool/commit/a9c688b7312c8dc786ea14246eb380f9b5a148cf  

LGTM. Pushed to master as obvious.