From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 92496469719 for ; Thu, 5 Mar 2020 14:41:45 +0300 (MSK) Date: Thu, 5 Mar 2020 11:41:44 +0000 From: Nikita Pettik Message-ID: <20200305114144.GE9655@tarantool.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 2/2] box: on cfg properly check memory quota List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On 05 Mar 01:14, Vladislav Shpilevoy wrote: > box_check_config() didn't check memtx_memory and vinyl_memory > upper bound. As a result, it was possible to set memory size > higher than what the quota allows as maximum. > > That worked only when box.cfg() was called first time, because > quota_init() does not check its value. Subsequent box.cfg() calls > use quota_set(), which aborts the program if a size is too big. > Only in debug mode. In release quota_set() also worked with any > sizes. > > Closes #4705 > --- LGTM.