From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A128C469719 for ; Thu, 5 Mar 2020 11:41:37 +0300 (MSK) Date: Thu, 5 Mar 2020 08:41:35 +0000 From: Nikita Pettik Message-ID: <20200305084135.GC9655@tarantool.org> References: <20200303161649.62470-1-k.sosnin@tarantool.org> <20200305054101.6btvhiglj6olbijv@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200305054101.6btvhiglj6olbijv@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2] iproto: add an empty body to the unprepare response List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Yukhin Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org On 05 Mar 08:41, Kirill Yukhin wrote: > Hello, > > On 03 мар 19:16, Chris Sosnin wrote: > > Absence of the body in the unprepare response forces users to perform > > additional checks to avoid errors. Adding an empty body fixes this problem. > > > > Closes #4769 > > --- > > branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4769-unprepare-response-body > > issue: https://github.com/tarantool/tarantool/issues/4769 > > > > As Nikita suggested, I created box/iproto.test.lua, and basically > > inserted wrappers for requests testing from box-py for future usage. > > Could you please rename the test to be not so generic? > Like box/gh-4769-iproto-unprep-body or whatever. Kirill, this test is going to assemble all iproto-related tests which don't rely on net.box module. Setting up all preparations required for raw iproto communication results in duplicating ~30-40 lines of code in each test file. > -- > Regards, Kirill Yukhin