From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8768C469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  5 Mar 2020 08:44:13 +0300 (MSK)
Date: Thu, 5 Mar 2020 08:44:12 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200305054412.4m5gfcqy267omjl7@tarantool.org>
References: <6b8602a297876492179b695f317e809bd425af79.1582209853.git.imun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6b8602a297876492179b695f317e809bd425af79.1582209853.git.imun@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] build: disable LUAJIT_ENABLE_PAIRSMM
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Hello,

On 20 фев 18:20, Igor Munkin wrote:
> Since this build flag has been removed as a result of reverting the
> tarantool/luajit@d4e985a, its definition in the corresponding Tarantool
> cmake file is irrelevant.
> 
> Furthermore, considering the breakage faced in #4770 the following tests
> are introduced:
> * the check whether space __pairs metamethod is set to space.pairs to
>   create a Lua Fun iterator that handles __pairs manually underneath.
> * the check whether pairs builtin behaviour doesn't change when __pairs
>   is set e.g. on space object.
> 
> Follow-up #4560
> Closes #4770
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
> 
> Issue: https://github.com/tarantool/tarantool/issues/4770
> Branch: https://github.com/tarantool/tarantool/tree/imun/gh-4770-broken-pairs
> 
> @ChangeLog (need to be added to already released versions):
> | The feature is removed since we faced the issues with the backward
> | compatibility between Lua 5.1 and Lua 5.2 within Tarantool modules as
> | well as other third party code (see #4770).
> 
>  cmake/luajit.cmake     |  1 -
>  test/box/misc.result   | 40 ++++++++++++++++++++++++++++++++++++++++
>  test/box/misc.test.lua | 15 +++++++++++++++

Could you please extract the test into separate file?

--
Regards, Kirill Yukhin