From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0B44E469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  5 Mar 2020 07:52:53 +0300 (MSK)
Date: Thu, 5 Mar 2020 07:52:53 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200305045253.dvllawadt2hntp5v@tarantool.org>
References: <20200228170130.81713-1-sergepetrenko@tarantool.org>
 <20200303082543.cxzoeyriccwi6q35@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200303082543.cxzoeyriccwi6q35@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] replication: fix rebootstrap in
 case the instance is listed in box.cfg.replication
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: kirichenkoga@gmail.com, tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Hello,

On 03 мар 11:25, Kirill Yukhin wrote:
> Hello,
> 
> On 28 фев 20:01, Serge Petrenko wrote:
> > When checking wheter rejoin is needed, replica loops through all the
> > instances in box.cfg.replication, which makes it believe that there is a
> > master holding files, needed by it, since it accounts itself just like
> > all other instances.
> > So make replica skip itself when finding an instance which holds files
> > needed by it, and determining whether rebootstrap is needed.
> > 
> > We already have a working test for the issue, it missed the issue due to
> > replica.lua replication settings. Fix replica.lua to optionally include
> > itself in box.cfg.replication, so that the corresponding test works
> > correctly.
> > 
> > Closes #4759
> > ---
> > https://github.com/tarantool/tarantool/issues/4759
> > https://github.com/tarantool/tarantool/tree/sp/gh-4759-rebootstrap-fix
> 
> THe patch LGTM. I've checked it into 2.2, 2.3 and master.

CHecked into 1.10 as well.

--
Regards, Kirill Yukhin