From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 27331469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  4 Mar 2020 16:47:01 +0300 (MSK)
Date: Wed, 4 Mar 2020 13:47:00 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200304134700.GA7936@tarantool.org>
References: <1581359737.397395198@f221.i.mail.ru>
 <11433298-80bb-336c-06a2-ce310634960f@tarantool.org>
 <20200227132113.GC12687@tarantool.org>
 <1583253766.42635729@f106.i.mail.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1583253766.42635729@f106.i.mail.ru>
Subject: Re: [Tarantool-patches] [PATCH] box: sql prepare and execute
 statistics should be reflected in box.stat()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Maria Khaydich <maria.khaydich@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches <tarantool-patches@dev.tarantool.org>

On 03 Mar 19:42, Maria Khaydich wrote:
> 
> > Please send smth like 'hotfix' for the last commit, I guess it is too late to force push to master.
>  
> If I understood you correctly:
> ----------------------------------------------------------------------
> Calling prepare and execute did not update corresponding request statistics
> in the box.stat table. This happened because methods that collect stats were
> never called where they should have been.
> 
> There was a bug in previous commit resulting in collecting statistics on
> box.execute twice in some cases.
>  
> Closes #4756
> ---
> diff --git a/test/sql/iproto.test.lua b/test/sql/iproto.test.lua
> index 9eac91d2c..ec1f37035 100644
> --- a/test/sql/iproto.test.lua
> +++ b/test/sql/iproto.test.lua
> @@ -249,11 +249,12 @@ p = box.stat().PREPARE.total
>  e = box.stat().EXECUTE.total
>  
>  s = box.prepare([[ SELECT ?; ]])
> -s:execute({42})

Why did you get rid of s:execute() call? Now both prepared:execute()
and box.execute() use the same function (sql_execute()) under the hood,
but it may change in future. Please, leave both test cases.

Lgtm otherwise.